[all-commits] [llvm/llvm-project] 8303b1: [cmake] Ensure that LINK_LIBS are dependencies for...

stephenneuendorffer via All-commits all-commits at lists.llvm.org
Mon May 4 08:46:42 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 8303b1f46af6c9838d3338479e5db2551daae248
      https://github.com/llvm/llvm-project/commit/8303b1f46af6c9838d3338479e5db2551daae248
  Author: Stephen Neuendorffer <stephen.neuendorffer at xilinx.com>
  Date:   2020-05-04 (Mon, 04 May 2020)

  Changed paths:
    M llvm/cmake/modules/AddLLVM.cmake

  Log Message:
  -----------
  [cmake] Ensure that LINK_LIBS are dependencies for object library targets

In MLIR, it is common for automatically generated headers to be included
in many places.  To avoid tracking these dependencies explicitly in
cmake, they are treated as part of a library which 'owns' the generated
header.  Users of the generated header link against the owning library.
However, object libraries don't actually 'link', so this dependence gets
lost.  This patch adds an explicit dependence for these generated headers
when creating object library targets to ensure that generated headers
are appropriately generated

Differential Revision: https://reviews.llvm.org/D79241




More information about the All-commits mailing list