[all-commits] [llvm/llvm-project] 1fcd23: [lldb/Core] Don't crash in GetSoftwareBreakpointTr...

Jonas Devlieghere via All-commits all-commits at lists.llvm.org
Fri Apr 24 09:11:01 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 1fcd234ac54a0bb9dcb14338db5a336d80321662
      https://github.com/llvm/llvm-project/commit/1fcd234ac54a0bb9dcb14338db5a336d80321662
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2020-04-24 (Fri, 24 Apr 2020)

  Changed paths:
    M lldb/source/Target/Platform.cpp

  Log Message:
  -----------
  [lldb/Core] Don't crash in GetSoftwareBreakpointTrapOpcode for unknown triples

This patch ensures we don't crash in GetSoftwareBreakpointTrapOpcode for
not-yet-supported architectures but rather continue with degraded
behavior.

I found the issue in the context of an invalid ArchSpec, which should be
handled further up the chain. In this patch I've also added an assert to
cover that, so we can still catch those issues.

Differential revision: https://reviews.llvm.org/D78588




More information about the All-commits mailing list