[all-commits] [llvm/llvm-project] bbcfce: Use FrameIndexTy for stack protector

[Alexander Richardson via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: bbcfce4badac3dfeb64c1bb413bbe0dc53eca326
      https://github.com/llvm/llvm-project/commit/bbcfce4badac3dfeb64c1bb413bbe0dc53eca326
  Author: Alex Richardson <Alexander.Richardson at cl.cam.ac.uk>
  Date:   2020-04-23 (Thu, 23 Apr 2020)

  Changed paths:
    M llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp

  Log Message:
  -----------
  Use FrameIndexTy for stack protector

Using getValueType() is not correct for architectures extended with CHERI since
we need a pointer type and not the value that is loaded. While stack
protector is useless when you have CHERI (since CHERI provides much
stronger security guarantees), we still have a test to check that we can
generate correct code for checks. Merging b281138a1b67ca4405b77d774adc3de72742e7a2
into our tree broke this test. Fix by using TLI.getFrameIndexTy().

Reviewed By: arsenm
Differential Revision: https://reviews.llvm.org/D77785


  Commit: f50bc823fe6f4279eb2f426dd54f3151878c0216
      https://github.com/llvm/llvm-project/commit/f50bc823fe6f4279eb2f426dd54f3151878c0216
  Author: Alex Richardson <Alexander.Richardson at cl.cam.ac.uk>
  Date:   2020-04-23 (Thu, 23 Apr 2020)

  Changed paths:
    A llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/on_the_fly_arg_change.ll.initially_disabled.expected
    M llvm/test/tools/UpdateTestChecks/update_test_checks/on_the_fly_arg_change.test
    M llvm/utils/UpdateTestChecks/common.py

  Log Message:
  -----------
  [UpdateTestChecks] Make generation of UTC_ARGS: comment more robust

We now use the argparse Action objects to determine the name of the flags.
This fixes cases where the key for the stored result ('dest') is not the
same as the command line flag (e.g. --enable/--disable).
Also add a test that --disabled can be part of the initial UTC_ARGS.

This is split out from D78478

Reviewed By: jdoerfert
Differential Revision: https://reviews.llvm.org/D78617


Compare: https://github.com/llvm/llvm-project/compare/12224162a1e7...f50bc823fe6f