[all-commits] [llvm/llvm-project] d3fdaf: [InlineSpiller] simplify insertReload() NFC

Nick Desaulniers via All-commits all-commits at lists.llvm.org
Tue Apr 21 08:33:50 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: d3fdafae0630ec7a5574ddda14f9e754c6426098
      https://github.com/llvm/llvm-project/commit/d3fdafae0630ec7a5574ddda14f9e754c6426098
  Author: Nick Desaulniers <ndesaulniers at google.com>
  Date:   2020-04-21 (Tue, 21 Apr 2020)

  Changed paths:
    M llvm/lib/CodeGen/InlineSpiller.cpp

  Log Message:
  -----------
  [InlineSpiller] simplify insertReload() NFC

Summary:
The repeated use of std::next() on a MachineBasicBlock::iterator was
clever, but we only need to reconstruct the iterator post creation of
the spill instruction.

This helps simplifying where we plan to place the spill, as discussed in
D77849.

>From here, we can simplify the code a little by flipping the return code
of a helper.

Reviewers: efriedma

Reviewed By: efriedma

Subscribers: qcolombet, hiraditya, llvm-commits, srhines

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D78520




More information about the All-commits mailing list