[all-commits] [llvm/llvm-project] 91f110: [libc++] Adjust XFAIL markup for modules tests on ...

Louis Dionne via All-commits all-commits at lists.llvm.org
Wed Apr 15 11:29:25 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 91f110f50ee66e0e8de7d4d82e9a4068b10afc91
      https://github.com/llvm/llvm-project/commit/91f110f50ee66e0e8de7d4d82e9a4068b10afc91
  Author: Louis Dionne <ldionne at apple.com>
  Date:   2020-04-15 (Wed, 15 Apr 2020)

  Changed paths:
    M libcxx/test/libcxx/modules/cinttypes_exports.compile.pass.cpp
    M libcxx/test/libcxx/modules/clocale_exports.compile.pass.cpp
    M libcxx/test/libcxx/modules/cstdint_exports.compile.pass.cpp
    M libcxx/test/libcxx/modules/inttypes_h_exports.compile.pass.cpp
    M libcxx/test/libcxx/modules/stdint_h_exports.compile.pass.cpp
    M libcxx/test/libcxx/modules/stds_include.sh.cpp

  Log Message:
  -----------
  [libc++] Adjust XFAIL markup for modules tests on single-threaded systems

When building these tests without modules in the whole test suite,
the __config_site macro definitions are not included anymore in the
%{compile_flags}. This causes the _LIBCPP_HAS_NO_THREADS define not
to be picked up, and the test to XPASS on single-threaded systems.

This is a stop-gap measure to fix the build bots, however the proper
solution would be to always pass the __config_site defines as compiler
macros, whether we build with modules or not.




More information about the All-commits mailing list