[all-commits] [llvm/llvm-project] bc3f54: [lit] Keep original cfg file case around.

Nico Weber via All-commits all-commits at lists.llvm.org
Wed Apr 15 11:18:32 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: bc3f54de1827e58655c34477d09211cbc42589bd
      https://github.com/llvm/llvm-project/commit/bc3f54de1827e58655c34477d09211cbc42589bd
  Author: Nico Weber <thakis at chromium.org>
  Date:   2020-04-15 (Wed, 15 Apr 2020)

  Changed paths:
    M llvm/cmake/modules/AddLLVM.cmake
    M llvm/utils/lit/lit/discovery.py
    M llvm/utils/lit/lit/llvm/config.py
    M llvm/utils/lit/tests/Inputs/config-map-discovery/driver.py
    M llvm/utils/llvm-lit/llvm-lit.in

  Log Message:
  -----------
  [lit] Keep original cfg file case around.

There's been some back and forth if the cfg paths in the
config_map should be normcase()d. The argument for is that
it allows using all-lower spelling in cmd on Windows, the
argument against that doing so is lossy.

Before the relative-paths-in-generated-lit.site.cfg.py work,
there was no downside to calling normcase(), but with it
we need a hack to recover the original case.

This time, normcase() the hashtable key, but store the original
cased key in addition to the value. This fixes both cons, at the
cost of a few bytes more memory.

Differential Revision: https://reviews.llvm.org/D78169




More information about the All-commits mailing list