[all-commits] [llvm/llvm-project] cbcb12: [MLIR] Handle in-place folding properly in greedy ...

Uday Bondhugula via All-commits all-commits at lists.llvm.org
Sat Apr 11 07:28:14 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: cbcb12fd44dfdb51bbf4489d213d96f17be3091f
      https://github.com/llvm/llvm-project/commit/cbcb12fd44dfdb51bbf4489d213d96f17be3091f
  Author: Uday Bondhugula <uday at polymagelabs.com>
  Date:   2020-04-11 (Sat, 11 Apr 2020)

  Changed paths:
    M mlir/include/mlir/Transforms/FoldUtils.h
    M mlir/lib/Transforms/Utils/FoldUtils.cpp
    M mlir/lib/Transforms/Utils/GreedyPatternRewriteDriver.cpp

  Log Message:
  -----------
  [MLIR] Handle in-place folding properly in greedy pattern rewrite driver

OperatioFolder::tryToFold performs both true folding and in a few
instances in-place updates through op rewrites. In the latter case, we
should still be applying the supplied pattern rewrites in the same
iteration; however this wasn't the case since tryToFold returned
success() for both true folding and in-place updates, and the patterns
for the in-place updated ops were being applied only in the next
iteration of the driver's outer loop. This fix would make it converge
faster.

Differential Revision: https://reviews.llvm.org/D77485




More information about the All-commits mailing list