[all-commits] [llvm/llvm-project] fc5d8b: [WebAssembly] Fix a sanitizer error in WasmEHPrepare

Heejin Ahn via All-commits all-commits at lists.llvm.org
Sat Apr 4 10:01:13 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: fc5d8b672b981027436a231f4e431d57bdf81407
      https://github.com/llvm/llvm-project/commit/fc5d8b672b981027436a231f4e431d57bdf81407
  Author: Heejin Ahn <aheejin at gmail.com>
  Date:   2020-04-04 (Sat, 04 Apr 2020)

  Changed paths:
    M llvm/lib/CodeGen/WasmEHPrepare.cpp

  Log Message:
  -----------
  [WebAssembly] Fix a sanitizer error in WasmEHPrepare

Summary:
D77423 started using a dominator tree in WasmEHPrepare, but we deleted
BBs in `prepareThrows` before we used the domtree in `prepareEHPads`,
and those CFG changes were not reflected in the domtree. This uses
`DomTreeUpdater` to make sure we update the domtree every time we delete
BBs from the CFG. This fixes ubsan/msan/expensive_check errors caught in
LLVM buildbots.

Reviewers: dschuff

Subscribers: sbc100, jgravelle-google, hiraditya, sunfish, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D77465




More information about the All-commits mailing list