[all-commits] [llvm/llvm-project] a63b5c: [CallSiteSplitting] Simplify isPredicateOnPHI & co...

Florian Hahn via All-commits all-commits at lists.llvm.org
Thu Apr 2 02:12:05 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: a63b5c9e53199b866b804164285a2c40531b31a1
      https://github.com/llvm/llvm-project/commit/a63b5c9e53199b866b804164285a2c40531b31a1
  Author: Florian Hahn <flo at fhahn.com>
  Date:   2020-04-02 (Thu, 02 Apr 2020)

  Changed paths:
    M llvm/lib/Transforms/Scalar/CallSiteSplitting.cpp
    M llvm/test/Transforms/CallSiteSplitting/callsite-split-or-phi.ll

  Log Message:
  -----------
  [CallSiteSplitting] Simplify isPredicateOnPHI & continue checking PHIs.

As pointed out by @thakis, currently CallSiteSplitting bails out after
checking the first PHI node. We should check all PHI nodes, until we
find one where call site splitting is beneficial.

This patch also slightly simplifies the code using BasicBlock::phis().

Reviewers: davidxl, junbuml, thakis

Reviewed By: davidxl

Differential Revision: https://reviews.llvm.org/D77089




More information about the All-commits mailing list