[all-commits] [llvm/llvm-project] 05bc58: [libc++] Do not rely on the environment to run fil...

[Louis Dionne via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 05bc588abbc38ad1f8f67994ec3bb606f0aaa983
      https://github.com/llvm/llvm-project/commit/05bc588abbc38ad1f8f67994ec3bb606f0aaa983
  Author: Louis Dionne <ldionne at apple.com>
  Date:   2020-03-31 (Tue, 31 Mar 2020)

  Changed paths:
    M libcxx/test/CMakeLists.txt
    M libcxx/test/support/filesystem_dynamic_test_helper.py
    M libcxx/test/support/filesystem_test_helper.h
    M libcxx/utils/libcxx/test/config.py

  Log Message:
  -----------
  [libc++] Do not rely on the environment to run filesystem tests

Previously, filesystem tests would require LIBCXX_FILESYSTEM_DYNAMIC_TEST_ROOT
to be present in the environment and to match the value provided when
compiling, as a macro. This has the problem that it only allows for the
filesystem tests to be run on the same machine they are created.

Instead, we create a temporary directory for each test. Technically,
this is tricky to do because we're relying on some of the code that
we're testing to do this. However, there's no other portable way of
creating temporary direcories in C++, so this is difficult to avoid.

Differential Revision: https://reviews.llvm.org/D76731