[all-commits] [llvm/llvm-project] 03bc31: [CorrelatedValuePropagation] Remove redundant if s...

Enna1 via All-commits all-commits at lists.llvm.org
Sat Mar 28 10:01:26 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 03bc311a16e292025f150ddafa9d468af562b897
      https://github.com/llvm/llvm-project/commit/03bc311a16e292025f150ddafa9d468af562b897
  Author: Enna1 <xumingjie1995 at outlook.com>
  Date:   2020-03-28 (Sat, 28 Mar 2020)

  Changed paths:
    M llvm/lib/Transforms/Scalar/CorrelatedValuePropagation.cpp

  Log Message:
  -----------
  [CorrelatedValuePropagation] Remove redundant if statement in processSelect()

This statement

    if (ReplaceWith == S) ReplaceWith = UndefValue::get(S->getType());

is introduced in https://reviews.llvm.org/rG35609d97ae89b8e13f40f4e6b9b056954f8baa83
to fix a case where unreachable code can cause select instruction
simplification to fail. In https://reviews.llvm.org/rGd10480657527ffb44ea213460fb3676a6b1300aa,
we begin to perform a depth-first walk of basic blocks. This means
we will not visit unreachable blocks. So we do not need this the
special check any more.

Differential Revision: https://reviews.llvm.org/D76753




More information about the All-commits mailing list