[all-commits] [llvm/llvm-project] 348735: AMDGPU: Stop setting attributes based on TargetOpt...

Matt Arsenault via All-commits all-commits at lists.llvm.org
Fri Mar 27 13:14:02 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 348735b723048411167b2244ebf5e2cd19bd869b
      https://github.com/llvm/llvm-project/commit/348735b723048411167b2244ebf5e2cd19bd869b
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2020-03-27 (Fri, 27 Mar 2020)

  Changed paths:
    M llvm/lib/Target/AMDGPU/AMDGPU.h
    M llvm/lib/Target/AMDGPU/AMDGPULibCalls.cpp
    M llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp
    M llvm/test/CodeGen/AMDGPU/inline-attr.ll

  Log Message:
  -----------
  AMDGPU: Stop setting attributes based on TargetOptions

Having arbitrary passes looking at the TargetOptions is pretty
messy. This was also disregarding if a function already had an
explicit attribute setting on it. opt/llc now add the attributes to
functions that don't specify the attribute. clang and lld do not call
the function to do this, which they maybe should.

This was also treating unsafe-fp-math as implying the others, and
setting the other attributes based on it. This is not done anywhere
else, and I'm not sure is correct based on the current description of
the option bit.

Effectively reverts 1d8cf2be89087a2babc1dc38b16040fad0a555e2




More information about the All-commits mailing list