[all-commits] [llvm/llvm-project] 0ab5b5: Fix denormal-fp-math flag and attribute interaction

Matt Arsenault via All-commits all-commits at lists.llvm.org
Fri Mar 27 12:49:09 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 0ab5b5b8581d9f2951575f7245824e6e4fc57dec
      https://github.com/llvm/llvm-project/commit/0ab5b5b8581d9f2951575f7245824e6e4fc57dec
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2020-03-27 (Fri, 27 Mar 2020)

  Changed paths:
    M llvm/include/llvm/CodeGen/CommandFlags.h
    M llvm/include/llvm/Target/TargetOptions.h
    M llvm/lib/CodeGen/CommandFlags.cpp
    M llvm/lib/Target/ARM/ARMAsmPrinter.cpp

  Log Message:
  -----------
  Fix denormal-fp-math flag and attribute interaction

Make these behave the same way unsafe-fp-math and co. The command line
flag should add the attribute to functions that do not already have
it, and leave existing attributes. The attribute is the actual
implementation, but the flag is useful in some testing situations.

AMDGPU has a variety of tests with denormals enabled/disabled that
would require a painful level of test duplication without a flag. This
doesn't expose setting the separate input/output modes, or add a flag
for the f32 version yet.

Tests will be included in future patch.




More information about the All-commits mailing list