[all-commits] [llvm/llvm-project] de98cf: [CodeGen] Add an alignment attribute to all sret p...

[Erik Pilkington via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: de98cf92e301ab559a7417f1eca5cfa53624c9e1
      https://github.com/llvm/llvm-project/commit/de98cf92e301ab559a7417f1eca5cfa53624c9e1
  Author: Erik Pilkington <erik.pilkington at gmail.com>
  Date:   2020-03-24 (Tue, 24 Mar 2020)

  Changed paths:
    M clang/lib/CodeGen/CGCall.cpp
    M clang/test/CodeGen/2006-05-19-SingleEltReturn.c
    M clang/test/CodeGen/aarch64-varargs.c
    M clang/test/CodeGen/aggregate-assign-call.c
    A clang/test/CodeGen/aligned-sret.c
    M clang/test/CodeGen/arc/arguments.c
    M clang/test/CodeGen/arm-aapcs-vfp.c
    M clang/test/CodeGen/arm-homogenous.c
    M clang/test/CodeGen/arm-neon-vld.c
    M clang/test/CodeGen/arm-varargs.c
    M clang/test/CodeGen/arm-vector-arguments.c
    M clang/test/CodeGen/arm-vfp16-arguments.c
    M clang/test/CodeGen/arm-vfp16-arguments2.cpp
    M clang/test/CodeGen/arm64-arguments.c
    M clang/test/CodeGen/arm64-microsoft-arguments.cpp
    M clang/test/CodeGen/arm64_32.c
    M clang/test/CodeGen/arm_neon_intrinsics.c
    M clang/test/CodeGen/blocks.c
    M clang/test/CodeGen/c11atomics-ios.c
    M clang/test/CodeGen/c11atomics.c
    M clang/test/CodeGen/lanai-arguments.c
    M clang/test/CodeGen/le32-arguments.c
    M clang/test/CodeGen/mcu-struct-return.c
    M clang/test/CodeGen/mingw-long-double.c
    M clang/test/CodeGen/mips-zero-sized-struct.c
    M clang/test/CodeGen/mips64-padding-arg.c
    M clang/test/CodeGen/ms_abi.c
    M clang/test/CodeGen/ppc64-align-struct.c
    M clang/test/CodeGen/ppc64-elf-abi.c
    M clang/test/CodeGen/ppc64-qpx-vector.c
    M clang/test/CodeGen/ppc64-soft-float.c
    M clang/test/CodeGen/ppc64-vector.c
    M clang/test/CodeGen/ppc64le-aggregates.c
    M clang/test/CodeGen/ppc64le-f128Aggregates.c
    M clang/test/CodeGen/regparm-struct.c
    M clang/test/CodeGen/renderscript.c
    M clang/test/CodeGen/riscv32-ilp32-abi.c
    M clang/test/CodeGen/riscv32-ilp32-ilp32f-abi.c
    M clang/test/CodeGen/riscv32-ilp32-ilp32f-ilp32d-abi.c
    M clang/test/CodeGen/riscv32-ilp32d-abi.c
    M clang/test/CodeGen/riscv32-ilp32f-abi.c
    M clang/test/CodeGen/riscv32-ilp32f-ilp32d-abi.c
    M clang/test/CodeGen/riscv64-lp64-abi.c
    M clang/test/CodeGen/riscv64-lp64-lp64f-abi.c
    M clang/test/CodeGen/riscv64-lp64-lp64f-lp64d-abi.c
    M clang/test/CodeGen/riscv64-lp64d-abi.c
    M clang/test/CodeGen/sparcv9-abi.c
    M clang/test/CodeGen/struct-passing.c
    M clang/test/CodeGen/systemz-abi-vector.c
    M clang/test/CodeGen/systemz-abi.c
    M clang/test/CodeGen/systemz-abi.cpp
    M clang/test/CodeGen/systemz-inline-asm.c
    M clang/test/CodeGen/vectorcall.c
    M clang/test/CodeGen/wasm-arguments.c
    M clang/test/CodeGen/wasm-varargs.c
    M clang/test/CodeGen/windows-struct-abi.c
    M clang/test/CodeGen/x86_32-arguments-darwin.c
    M clang/test/CodeGen/x86_32-arguments-iamcu.c
    M clang/test/CodeGen/x86_64-arguments-nacl.c
    M clang/test/CodeGen/x86_64-arguments-win32.c
    M clang/test/CodeGen/x86_64-arguments.c
    M clang/test/CodeGenCXX/arm-cc.cpp
    M clang/test/CodeGenCXX/builtin-source-location.cpp
    M clang/test/CodeGenCXX/call-with-static-chain.cpp
    M clang/test/CodeGenCXX/conditional-gnu-ext.cpp
    M clang/test/CodeGenCXX/cxx1z-copy-omission.cpp
    M clang/test/CodeGenCXX/cxx1z-lambda-star-this.cpp
    M clang/test/CodeGenCXX/exceptions.cpp
    M clang/test/CodeGenCXX/homogeneous-aggregates.cpp
    M clang/test/CodeGenCXX/lambda-expressions.cpp
    M clang/test/CodeGenCXX/microsoft-abi-byval-sret.cpp
    M clang/test/CodeGenCXX/microsoft-abi-byval-thunks.cpp
    M clang/test/CodeGenCXX/microsoft-abi-cdecl-method-sret.cpp
    M clang/test/CodeGenCXX/microsoft-abi-eh-cleanups.cpp
    M clang/test/CodeGenCXX/microsoft-abi-sret-and-byval.cpp
    M clang/test/CodeGenCXX/microsoft-abi-vmemptr-conflicts.cpp
    M clang/test/CodeGenCXX/regcall.cpp
    M clang/test/CodeGenCXX/stack-reuse-miscompile.cpp
    M clang/test/CodeGenCXX/stack-reuse.cpp
    M clang/test/CodeGenCXX/temporaries.cpp
    M clang/test/CodeGenCXX/thiscall-struct-return.cpp
    M clang/test/CodeGenCXX/thunk-returning-memptr.cpp
    M clang/test/CodeGenCXX/thunks.cpp
    M clang/test/CodeGenCXX/trivial_abi.cpp
    M clang/test/CodeGenCXX/unknown-anytype.cpp
    M clang/test/CodeGenCXX/wasm-args-returns.cpp
    M clang/test/CodeGenCXX/x86_32-arguments.cpp
    M clang/test/CodeGenCXX/x86_64-arguments.cpp
    M clang/test/CodeGenCoroutines/coro-await.cpp
    M clang/test/CodeGenCoroutines/coro-gro-nrvo.cpp
    M clang/test/CodeGenObjC/arc.m
    M clang/test/CodeGenObjC/direct-method.m
    M clang/test/CodeGenObjC/nontrivial-c-struct-exception.m
    M clang/test/CodeGenObjC/objc-non-trivial-struct-nrvo.m
    M clang/test/CodeGenObjC/stret-1.m
    M clang/test/CodeGenObjC/weak-in-c-struct.m
    M clang/test/CodeGenObjCXX/objc-struct-cxx-abi.mm
    M clang/test/CodeGenOpenCL/addr-space-struct-arg.cl
    M clang/test/CodeGenOpenCL/amdgpu-abi-struct-coerce.cl
    M clang/test/CodeGenOpenCLCXX/addrspace-of-this.cl
    M clang/test/Modules/templates.mm

  Log Message:
  -----------
  [CodeGen] Add an alignment attribute to all sret parameters

This fixes a miscompile when the parameter is actually underaligned.
rdar://58316406

Differential revision: https://reviews.llvm.org/D74183