[all-commits] [llvm/llvm-project] 0b18b5: [lldb-vscode] Don't use SBLaunchInfo in request_at...

Anton Kolesov via All-commits all-commits at lists.llvm.org
Fri Mar 20 10:15:56 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 0b18b568e91a3ebe3ab33d13328a1614fb94cf07
      https://github.com/llvm/llvm-project/commit/0b18b568e91a3ebe3ab33d13328a1614fb94cf07
  Author: Anton Kolesov <Anton.Kolesov at synopsys.com>
  Date:   2020-03-20 (Fri, 20 Mar 2020)

  Changed paths:
    M lldb/tools/lldb-vscode/lldb-vscode.cpp

  Log Message:
  -----------
  [lldb-vscode] Don't use SBLaunchInfo in request_attach

If LLDB attaches to an already running target, then structure SBAttachInfo is
used instead of SBLaunchInfo. lldb-vscode function request_attach sets some
values to g_vsc.launch_info, however this field is then not passed anywhere, so
this action has no effect. This commit removes invocation of
SBLaunchInfo::SetDetachOnError, which has no equivalent in SBAttachInfo.

File package.json doesn't describe detachOnError property for "attach" request
type, therefore it is not needed to update it.

Differential Revision: https://reviews.llvm.org/D76351




More information about the All-commits mailing list