[all-commits] [llvm/llvm-project] dc4cd4: [clangd] Add a textual fallback for go-to-definition

Sam McCall via All-commits all-commits at lists.llvm.org
Thu Mar 12 13:33:23 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: dc4cd43904df92565dbacaa501db98eb9683551b
      https://github.com/llvm/llvm-project/commit/dc4cd43904df92565dbacaa501db98eb9683551b
  Author: Sam McCall <sam.mccall at gmail.com>
  Date:   2020-03-12 (Thu, 12 Mar 2020)

  Changed paths:
    M clang-tools-extra/clangd/FindSymbols.cpp
    M clang-tools-extra/clangd/FindSymbols.h
    M clang-tools-extra/clangd/XRefs.cpp
    M clang-tools-extra/clangd/XRefs.h
    M clang-tools-extra/clangd/unittests/XRefsTests.cpp

  Log Message:
  -----------
  [clangd] Add a textual fallback for go-to-definition

Summary:
This facilitates performing go-to-definition in contexts where AST-based
resolution does not work, such as comments, string literals, preprocessor
disabled regions, and macro definitions, based on textual lookup in the index.

Partially fixes https://github.com/clangd/clangd/issues/241

Reviewers: sammccall

Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, kadircet, usaxena95, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D72874




More information about the All-commits mailing list