[all-commits] [llvm/llvm-project] 5f9fcf: Replace getAs with castAs to fix null dereference ...

Simon Pilgrim via All-commits all-commits at lists.llvm.org
Thu Mar 12 07:59:37 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 5f9fcfb29e4e30932909ce648ad556a3890e6dce
      https://github.com/llvm/llvm-project/commit/5f9fcfb29e4e30932909ce648ad556a3890e6dce
  Author: Simon Pilgrim <llvm-dev at redking.me.uk>
  Date:   2020-03-12 (Thu, 12 Mar 2020)

  Changed paths:
    M clang/lib/AST/ASTContext.cpp

  Log Message:
  -----------
  Replace getAs with castAs to fix null dereference static analyzer warnings.

Use castAs as we know the cast should succeed (and castAs will assert if it doesn't) and we're dereferencing it directly in the canAssignObjCInterfaces call.


  Commit: dbde39e485b5c00b9ad809d169e1650aa2104114
      https://github.com/llvm/llvm-project/commit/dbde39e485b5c00b9ad809d169e1650aa2104114
  Author: Simon Pilgrim <llvm-dev at redking.me.uk>
  Date:   2020-03-12 (Thu, 12 Mar 2020)

  Changed paths:
    M clang/lib/AST/DeclCXX.cpp

  Log Message:
  -----------
  Fix static analyzer null dereference warning. NFCI.


  Commit: 7c2b3c9dda37ab25a6849a3670f1bfda6aa17e5e
      https://github.com/llvm/llvm-project/commit/7c2b3c9dda37ab25a6849a3670f1bfda6aa17e5e
  Author: Simon Pilgrim <llvm-dev at redking.me.uk>
  Date:   2020-03-12 (Thu, 12 Mar 2020)

  Changed paths:
    M clang/lib/AST/DeclCXX.cpp

  Log Message:
  -----------
  Replace getAs with castAs to fix null dereference static analyzer warnings.

Use castAs as we know the cast should succeed (and castAs will assert if it doesn't) and we're dereferencing it directly in the getThisType/getThisObjectType calls.


Compare: https://github.com/llvm/llvm-project/compare/3e53bf5781e0...7c2b3c9dda37


More information about the All-commits mailing list