[all-commits] [llvm/llvm-project] 1c70de: [libunwind] Remove __FILE__ and __LINE__ from erro...

Leonard Chan via All-commits all-commits at lists.llvm.org
Tue Mar 10 18:59:56 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 1c70dec18c7e530264cc70841cc60f385259b9e0
      https://github.com/llvm/llvm-project/commit/1c70dec18c7e530264cc70841cc60f385259b9e0
  Author: Leonard Chan <leonardchan at google.com>
  Date:   2020-03-10 (Tue, 10 Mar 2020)

  Changed paths:
    M libunwind/src/config.h

  Log Message:
  -----------
  [libunwind] Remove __FILE__ and __LINE__ from error reporting

We were seeing non-deterministic binary size differences depending on which
toolchain was used to build fuchsia. This is because libunwind embeded the
FILE path into a logging macro, even for release builds, which makes the code
dependent on the build directory.

This removes the file and line number from the error message. This is
consistent with how other runtimes report error, e.g.
https://github.com/llvm/llvm-project/blob/master/libcxxabi/src/abort_message.cpp#L30.

Differential Revision: https://reviews.llvm.org/D75890




More information about the All-commits mailing list