[all-commits] [llvm/llvm-project] 1ca1e0: [lldb] Break up CommandObjectDisassemble::DoExecute

Pavel Labath via All-commits all-commits at lists.llvm.org
Tue Mar 10 06:08:29 PDT 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 1ca1e08e7544aea88d5978284a1c18086458d6c0
      https://github.com/llvm/llvm-project/commit/1ca1e08e7544aea88d5978284a1c18086458d6c0
  Author: Pavel Labath <pavel at labath.sk>
  Date:   2020-03-10 (Tue, 10 Mar 2020)

  Changed paths:
    M lldb/source/Commands/CommandObjectDisassemble.cpp
    M lldb/source/Commands/CommandObjectDisassemble.h
    M lldb/test/Shell/Commands/command-disassemble.s

  Log Message:
  -----------
  [lldb] Break up CommandObjectDisassemble::DoExecute

The function consisted of a complicated set of conditions to compute the
address ranges which are to be disassembled (depending on the mode
selected by command line switches). This patch creates a separate
function for each mode, so that DoExecute is only left with the task of
figuring out how to dump the relevant ranges.

This is NFC-ish, except for one change in the error message, which is
actually an improvement.




More information about the All-commits mailing list