[all-commits] [llvm/llvm-project] af1c2e: [ARM] Fix dropped dollar sign from symbols in bran...

Lucas Duarte Prates via All-commits all-commits at lists.llvm.org
Fri Mar 6 08:25:20 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: af1c2e561e5fbd584093b1200cf364fe1b7ec7c4
      https://github.com/llvm/llvm-project/commit/af1c2e561e5fbd584093b1200cf364fe1b7ec7c4
  Author: Lucas Prates <lucas.prates at arm.com>
  Date:   2020-03-06 (Fri, 06 Mar 2020)

  Changed paths:
    M llvm/lib/Target/ARM/AsmParser/ARMAsmParser.cpp
    M llvm/test/MC/ARM/arm-branches.s

  Log Message:
  -----------
  [ARM] Fix dropped dollar sign from symbols in branch targets

Summary:
ARMAsmParser was incorrectly dropping a leading dollar sign character
from symbol names in targets of branch instructions. This was caused by
an incorrect assumption that the contents following the dollar sign
token should be handled as a constant immediate, similarly to the #
token.

This patch avoids the operand parsing from consuming the dollar sign
token when it is followed by an identifier, making sure it is properly
parsed as part of the expression.

Reviewers: efriedma

Reviewed By: efriedma

Subscribers: danielkiss, chill, carwil, vhscampos, kristof.beyls, hiraditya, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D73176




More information about the All-commits mailing list