[all-commits] [llvm/llvm-project] 791efb: [ARM] Rewrite ARMAttributeParser

[Fangrui Song via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 791efb148f28e89a62413bcefd242911c6974ea6
      https://github.com/llvm/llvm-project/commit/791efb148f28e89a62413bcefd242911c6974ea6
  Author: Fangrui Song <maskray at google.com>
  Date:   2020-03-05 (Thu, 05 Mar 2020)

  Changed paths:
    M lld/ELF/InputFiles.cpp
    M lld/test/ELF/arm-tag-vfp-args-illegal.s
    M lld/test/ELF/invalid/bad-arm-attributes.s
    R lld/test/ELF/invalid/bad-arm-attributes2.s
    M llvm/include/llvm/Object/ELFObjectFile.h
    M llvm/include/llvm/Support/ARMAttributeParser.h
    M llvm/include/llvm/Support/DataExtractor.h
    M llvm/lib/Object/ELFObjectFile.cpp
    M llvm/lib/Support/ARMAttributeParser.cpp
    M llvm/tools/llvm-readobj/ELFDumper.cpp
    M llvm/unittests/Support/ARMAttributeParser.cpp

  Log Message:
  -----------
  [ARM] Rewrite ARMAttributeParser

* Delete boilerplate
* Change functions to return `Error`
* Test parsing errors
* Update callers of ARMAttributeParser::parse() to check the `Error` return value.

Since this patch touches nearly everything in the file, I apply
http://llvm.org/docs/Proposals/VariableNames.html and change variable
names to lower case.

Reviewed By: compnerd

Differential Revision: https://reviews.llvm.org/D75015