[all-commits] [llvm/llvm-project] 5b2cc6: [mlir][ods] Improve integer signedness modelling

Lei Zhang via All-commits all-commits at lists.llvm.org
Wed Mar 4 12:07:05 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 5b2cc6c3d0024d0d05e881d74d63be0ea2dca546
      https://github.com/llvm/llvm-project/commit/5b2cc6c3d0024d0d05e881d74d63be0ea2dca546
  Author: Lei Zhang <antiagainst at google.com>
  Date:   2020-03-04 (Wed, 04 Mar 2020)

  Changed paths:
    M mlir/include/mlir/Dialect/LLVMIR/LLVMOps.td
    M mlir/include/mlir/Dialect/SPIRV/SPIRVBase.td
    M mlir/include/mlir/Dialect/StandardOps/IR/Ops.td
    M mlir/include/mlir/IR/OpBase.td
    M mlir/test/Dialect/LLVMIR/global.mlir
    M mlir/test/Dialect/Loops/invalid.mlir
    M mlir/test/Dialect/SPIRV/ops.mlir
    M mlir/test/IR/attribute.mlir
    M mlir/test/IR/invalid-ops.mlir
    M mlir/test/lib/TestDialect/TestOps.td
    M mlir/test/mlir-tblgen/predicate.td
    M mlir/test/mlir-tblgen/types.mlir

  Log Message:
  -----------
  [mlir][ods] Improve integer signedness modelling

A previous commit added support for integer signedness in C++
IntegerType. This change introduces ODS definitions for
integer types and integer (element) attributes w.r.t. signedness.

This commit also updates various existing definitions' descriptions
to mention signless where suitable to make it more clear.

Positive and non-negative integer attributes are removed to avoid
the explosion of subclasses. Instead, one should use more atmoic
constraints together with Confined to model that. For example,
`Confined<..., [IntPositive]>`.

Differential Revision: https://reviews.llvm.org/D75610




More information about the All-commits mailing list