[all-commits] [llvm/llvm-project] e6b818: [clangd] Fix early selection for non-vardecl decla...

kadir çetinkaya via All-commits all-commits at lists.llvm.org
Wed Mar 4 02:01:47 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: e6b8181895b96740dbe54aca036aa237e0a8363d
      https://github.com/llvm/llvm-project/commit/e6b8181895b96740dbe54aca036aa237e0a8363d
  Author: Kadir Cetinkaya <kadircet at google.com>
  Date:   2020-03-04 (Wed, 04 Mar 2020)

  Changed paths:
    M clang-tools-extra/clangd/Selection.cpp
    M clang-tools-extra/clangd/unittests/HoverTests.cpp
    M clang-tools-extra/clangd/unittests/SelectionTests.cpp

  Log Message:
  -----------
  [clangd] Fix early selection for non-vardecl declarators

Summary:
Selection tree was performing an early claim only for VarDecls, but
there are other cases where we can have declarators, e.g. FieldDecls. This patch
extends the early claim logic to all types of declarators.

Fixes https://github.com/clangd/clangd/issues/292

Reviewers: sammccall

Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, usaxena95, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D75106


  Commit: ec7c8bae84557a987d8dce701e8d1ef9183f6cf3
      https://github.com/llvm/llvm-project/commit/ec7c8bae84557a987d8dce701e8d1ef9183f6cf3
  Author: Kadir Cetinkaya <kadircet at google.com>
  Date:   2020-03-04 (Wed, 04 Mar 2020)

  Changed paths:
    M clang-tools-extra/clangd/ParsedAST.cpp
    M clang-tools-extra/clangd/unittests/ParsedASTTests.cpp

  Log Message:
  -----------
  [clangd] Make use of syntax tokens in ReplayPreamble

Summary: Replace usage of RawLexer with syntax tokens inside ReplayPreamble.

Reviewers: sammccall

Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, usaxena95, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D74842


Compare: https://github.com/llvm/llvm-project/compare/497c110e8734...ec7c8bae8455


More information about the All-commits mailing list