[all-commits] [llvm/llvm-project] bcee89: [mlir] Hotfix - Fix Windows build

Nicolas Vasilache via All-commits all-commits at lists.llvm.org
Mon Mar 2 19:49:48 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: bcee8982a2931960ca29a9e95e3d10355e7393ab
      https://github.com/llvm/llvm-project/commit/bcee8982a2931960ca29a9e95e3d10355e7393ab
  Author: Nicolas Vasilache <ntv at google.com>
  Date:   2020-03-02 (Mon, 02 Mar 2020)

  Changed paths:
    M mlir/lib/ExecutionEngine/CMakeLists.txt

  Log Message:
  -----------
  [mlir] Hotfix - Fix Windows build

This revision adds a static `mlir_c_runner_utils_static` library
for the sole purpose of being linked into `mlir_runner_utils` on
Windows.

It was previously reported that:
```

`add_llvm_library(mlir_c_runner_utils SHARED CRunnerUtils.cpp)`

produces *only* a dll on windows, the linking of mlir_runner_utils fails
because target_link_libraries is looking for a .lib file as opposed to a
.dll file. I think this may be a case where either we need to use
LINK_LIBS or explicitly build a static lib as well, but I haven't tried
either yet.
```




More information about the All-commits mailing list