[all-commits] [llvm/llvm-project] 14aef5: [libcxx] Fix _LIBCPP_HAS_THREAD_API_EXTERNAL build

Mikhail Maltsev via All-commits all-commits at lists.llvm.org
Wed Feb 26 09:54:54 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 14aef5367d0dfc2ec10ffdbbc3fb8abbc530f4d1
      https://github.com/llvm/llvm-project/commit/14aef5367d0dfc2ec10ffdbbc3fb8abbc530f4d1
  Author: Mikhail Maltsev <mikhail.maltsev at arm.com>
  Date:   2020-02-26 (Wed, 26 Feb 2020)

  Changed paths:
    M libcxx/include/__threading_support

  Log Message:
  -----------
  [libcxx] Fix _LIBCPP_HAS_THREAD_API_EXTERNAL build

Summary:
The definition of `__libcpp_timed_backoff_policy` and the declaration of
`__libcpp_thread_poll_with_backoff` must not be guarded by
  #if !defined(_LIBCPP_HAS_THREAD_API_EXTERNAL)
because the definitions of `__libcpp_timed_backoff_policy::operator()`
and `__libcpp_thread_poll_with_backoff` aren't guarded by this macro
(and this is correct because these two functions are implemented in
terms of other libc++ functions and don't interact with the host
threading library).

Reviewers: ldionne, __simt__, EricWF, mclow.lists

Reviewed By: ldionne

Subscribers: dexonsmith, libcxx-commits

Tags: #libc

Differential Revision: https://reviews.llvm.org/D75191




More information about the All-commits mailing list