[all-commits] [llvm/llvm-project] 92c805: [MIPS GlobalISel] RegBankSelect G_MERGE_VALUES and...

petar-avramovic via All-commits all-commits at lists.llvm.org
Wed Feb 19 01:10:45 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 92c80529ddb3ae147e9e58aed8d68b4aa2ea2379
      https://github.com/llvm/llvm-project/commit/92c80529ddb3ae147e9e58aed8d68b4aa2ea2379
  Author: Petar Avramovic <Petar.Avramovic at rt-rk.com>
  Date:   2020-02-19 (Wed, 19 Feb 2020)

  Changed paths:
    M llvm/lib/Target/Mips/MipsCallLowering.cpp
    M llvm/lib/Target/Mips/MipsInstrFPU.td
    M llvm/lib/Target/Mips/MipsInstructionSelector.cpp
    M llvm/lib/Target/Mips/MipsLegalizerInfo.cpp
    M llvm/lib/Target/Mips/MipsRegisterBankInfo.cpp
    M llvm/lib/Target/Mips/MipsRegisterBankInfo.h
    M llvm/test/CodeGen/Mips/GlobalISel/instruction-select/float_args.mir
    M llvm/test/CodeGen/Mips/GlobalISel/instruction-select/phi.mir
    M llvm/test/CodeGen/Mips/GlobalISel/instruction-select/select.mir
    M llvm/test/CodeGen/Mips/GlobalISel/instruction-select/sitofp_and_uitofp.mir
    M llvm/test/CodeGen/Mips/GlobalISel/irtranslator/float_args.ll
    M llvm/test/CodeGen/Mips/GlobalISel/legalizer/phi.mir
    M llvm/test/CodeGen/Mips/GlobalISel/legalizer/select.mir
    M llvm/test/CodeGen/Mips/GlobalISel/legalizer/sitofp_and_uitofp.mir
    M llvm/test/CodeGen/Mips/GlobalISel/llvm-ir/float_args.ll
    M llvm/test/CodeGen/Mips/GlobalISel/llvm-ir/phi.ll
    M llvm/test/CodeGen/Mips/GlobalISel/llvm-ir/select.ll
    M llvm/test/CodeGen/Mips/GlobalISel/regbankselect/float_args.mir
    M llvm/test/CodeGen/Mips/GlobalISel/regbankselect/phi.mir
    M llvm/test/CodeGen/Mips/GlobalISel/regbankselect/select.mir
    M llvm/test/CodeGen/Mips/GlobalISel/regbankselect/sitofp_and_uitofp.mir

  Log Message:
  -----------
  [MIPS GlobalISel] RegBankSelect G_MERGE_VALUES and G_UNMERGE_VALUES

Consider large operands in G_MERGE_VALUES and G_UNMERGE_VALUES as
Ambiguous during regbank selection.
Introducing new InstType AmbiguousWithMergeOrUnmerge which will
allow us to recognize whether to narrow scalar or use s64:fprb.

This change exposed a bug when reusing data from TypeInfoForMF.
Thus when Instr is about to get destroyed (using narrow scalar)
clear its data in TypeInfoForMF. Internal data is saved based on
Instr's address, and it will no longer be valid.
Add detailed asserts for InstType and operand size.

Generate generic instructions instead of MIPS target instructions
during argument lowering and custom legalizer.
Select G_UNMERGE_VALUES and G_MERGE_VALUES when proper banks are
selected: {s32:gprb, s32:gprb, s64:fprb} for G_UNMERGE_VALUES and
{s64:fprb, s32:gprb, s32:gprb} for G_MERGE_VALUES.
Update tests. One improvement is when floating point argument in
gpr(or two gprs) gets passed to another function through gpr
unnecessary fpr-to-gpr moves are no longer generated.

Differential Revision: https://reviews.llvm.org/D74623




More information about the All-commits mailing list