[all-commits] [llvm/llvm-project] 5573ab: [DependenceAnalysis] Dependecies for loads marked ...

[ebrevnov via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 5573abceab5eb9c6964b7249eae21f80a88ebf2e
      https://github.com/llvm/llvm-project/commit/5573abceab5eb9c6964b7249eae21f80a88ebf2e
  Author: Evgeniy Brevnov <evgueni.brevnov at gmail.com>
  Date:   2020-02-14 (Fri, 14 Feb 2020)

  Changed paths:
    M llvm/lib/Analysis/MemoryDependenceAnalysis.cpp
    A llvm/test/Analysis/MemoryDependenceAnalysis/InvariantLoad.ll

  Log Message:
  -----------
  [DependenceAnalysis] Dependecies for loads marked with "ivnariant.load" should not be shared with general accesses(PR42151).

Summary:
This is second attempt to fix the problem with incorrect dependencies reported in presence of invariant load. Initial fix (https://reviews.llvm.org/D64405) was reverted due to a regression reported in https://reviews.llvm.org/D70516.

The original fix changed caching behavior for invariant loads. Namely such loads are not put into the second level cache (NonLocalDepInfo). The problem with that fix is the first level cache  (CachedNonLocalPointerInfo) still works as if invariant loads were in the second level cache. The solution is in addition to not putting dependence results into the second level cache avoid putting info about invariant loads into the first level cache as well.

Reviewers: jdoerfert, reames, hfinkel, efriedma

Reviewed By: jdoerfert

Subscribers: DaniilSuchkov, hiraditya, bmahjour, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D73027