[all-commits] [llvm/llvm-project] 60cba3: [Clang] When -ftime-trace is used, clean CompilerI...

[Alexandre Ganea via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 60cba345ca395ea991d7f2596c4a93439fbf9924
      https://github.com/llvm/llvm-project/commit/60cba345ca395ea991d7f2596c4a93439fbf9924
  Author: Alexandre Ganea <alexandre.ganea at ubisoft.com>
  Date:   2020-02-12 (Wed, 12 Feb 2020)

  Changed paths:
    M clang/tools/driver/cc1_main.cpp

  Log Message:
  -----------
  [Clang] When -ftime-trace is used, clean CompilerInstance::OutputFiles before exiting cc_main()

This fixes cc1 execution when '-disable-free' is not used (currently not the case, that flag is always used for cc1).


  Commit: 20f1abe306d030e99f56185a3aa077ffadf59b8a
      https://github.com/llvm/llvm-project/commit/20f1abe306d030e99f56185a3aa077ffadf59b8a
  Author: Alexandre Ganea <alexandre.ganea at ubisoft.com>
  Date:   2020-02-12 (Wed, 12 Feb 2020)

  Changed paths:
    M clang/include/clang/Driver/Job.h
    M clang/lib/Driver/Driver.cpp
    M clang/lib/Driver/Job.cpp
    M clang/lib/Driver/ToolChains/Clang.cpp
    M clang/test/Driver/cc1-spawnprocess.c

  Log Message:
  -----------
  [Clang] Limit -fintegrated-cc1 to only one TU

As discussed in https://reviews.llvm.org/D74447, this patch disables integrated-cc1 behavior if there's more than one job to be executed. This is meant to limit memory bloating, given that currently jobs don't clean up after execution (-disable-free is always active in cc1 mode).

I see this behavior as temporary until release 10.0 ships (to ease merging of this patch), then we'll reevaluate the situation, see if D74447 makes more sense on the long term.

Differential Revision: https://reviews.llvm.org/D74490


Compare: https://github.com/llvm/llvm-project/compare/10382ebe8f3f...20f1abe306d0