[all-commits] [llvm/llvm-project] b1c7bf: [DebugInfo] Reject line tables of version > 5

James Henderson via All-commits all-commits at lists.llvm.org
Mon Feb 10 06:45:08 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: b1c7bfe6da2b5d171d025bf261f62773470cfc05
      https://github.com/llvm/llvm-project/commit/b1c7bfe6da2b5d171d025bf261f62773470cfc05
  Author: James Henderson <james.henderson at sony.com>
  Date:   2020-02-10 (Mon, 10 Feb 2020)

  Changed paths:
    M llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp
    M llvm/unittests/DebugInfo/DWARF/DWARFDebugLineTest.cpp

  Log Message:
  -----------
  [DebugInfo] Reject line tables of version > 5

If a debug line section with version of greater than 5 is encountered,
prior to this change the parser would accept it and treat it as version
5. This might work to some extent, but then it might not at all, as it
really depends on the format of the unspecified future version, which
will be different (otherwise there would be no point in changing the
version number). Any information we could provide has a good chance of
being invalid, so we should just refuse to parse such tables.

Reviewed by: dblaikie, MaskRay

Differential Revision: https://reviews.llvm.org/D74204




More information about the All-commits mailing list