[all-commits] [llvm/llvm-project] c96eee: [CMake] compiler-rt: Add COMPILER_RT_BUILTINS_ENAB...

Petr Hosek via All-commits all-commits at lists.llvm.org
Fri Jan 31 15:57:52 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: c96eeebca8b074d2f5cdbd8de3dc42a31b3ea8d7
      https://github.com/llvm/llvm-project/commit/c96eeebca8b074d2f5cdbd8de3dc42a31b3ea8d7
  Author: Petr Hosek <phosek at google.com>
  Date:   2020-01-31 (Fri, 31 Jan 2020)

  Changed paths:
    M compiler-rt/lib/builtins/CMakeLists.txt

  Log Message:
  -----------
  [CMake] compiler-rt: Add COMPILER_RT_BUILTINS_ENABLE_PIC

The configuration for -fPIC in the builtins library when built standalone
is unconditional, stating that the flags would "normally be added... by
the llvm cmake step"

This is untrue, as the llvm cmake step checks LLVM_ENABLE_PIC, which allows
a client to turn off -fPIC.

I've added an option when compiler-rt builtins are configured standalone, such
as when built as part of the LLVM runtimes system, to guard the application of
-fPIC for users that want it.

Patch By: JamesNagurne

Differential Revision: https://reviews.llvm.org/D72950




More information about the All-commits mailing list