[all-commits] [llvm/llvm-project] 6cc6e8: Fix helptext for opt/llc after 14fc20ca6

Nemanja Ivanovic via All-commits all-commits at lists.llvm.org
Thu Jan 30 06:36:13 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 6cc6e89c11de514fc9dfff99ca093f7013003e7f
      https://github.com/llvm/llvm-project/commit/6cc6e89c11de514fc9dfff99ca093f7013003e7f
  Author: Nemanja Ivanovic <nemanja.i.ibm at gmail.com>
  Date:   2020-01-30 (Thu, 30 Jan 2020)

  Changed paths:
    M llvm/lib/Target/X86/MCTargetDesc/X86AsmBackend.cpp

  Log Message:
  -----------
  Fix helptext for opt/llc after 14fc20ca6

The commit https://reviews.llvm.org/rG14fc20ca6 added some options to the X86
back end that cause the help text for opt/llc to become much harder to read.
The issue is that the cl::value_desc is part of the option name and is used to
compute the indentation of the description text (i.e. the maximum length option
name is what everything aligns to). Since the commit puts a large number of
characters into that text, everything is aligned to that width.

This patch just reformats the option so that the description is contained in the
description and the list of possible values is within the angle brackets.

Note: the readability issue of the helptext was fixed in commit
      70cbf8c71c510077baadcad305fea6f62e830b06, but the re-formatting wasn't
      added on that commit so I am still committing this.

Differential revision: https://reviews.llvm.org/D73267




More information about the All-commits mailing list