[all-commits] [llvm/llvm-project] 1ef8e8: [X86] Don't exit from foldOffsetIntoAddress if the...

topperc via All-commits all-commits at lists.llvm.org
Wed Jan 29 21:32:48 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 1ef8e8b41429a1c2440ddbbcb1fc19ba1e8fcc57
      https://github.com/llvm/llvm-project/commit/1ef8e8b41429a1c2440ddbbcb1fc19ba1e8fcc57
  Author: Craig Topper <craig.topper at gmail.com>
  Date:   2020-01-29 (Wed, 29 Jan 2020)

  Changed paths:
    M llvm/lib/Target/X86/X86ISelDAGToDAG.cpp

  Log Message:
  -----------
  [X86] Don't exit from foldOffsetIntoAddress if the Offset is 0, but AM.Disp is non-zero.

This is an alternate fix for the issue D73606 was trying to
solve.

The main issue here is that we bailed out of
foldOffsetIntoAddress if Offset is 0. But if we just found a
symbolic displacement and AM.Disp became non-zero
earlier, we still need to validate that AM.Disp with the symbolic
displacement.

This passes fold-add-pcrel.ll.

Differential Revision: https://reviews.llvm.org/D73608




More information about the All-commits mailing list