[all-commits] [llvm/llvm-project] 664d2f: Add tanh lowering from Standard dialect to NVVM an...

[dfki-jugr via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 664d2f5bad3eeef5e7cd59492937d1c34feb8642
      https://github.com/llvm/llvm-project/commit/664d2f5bad3eeef5e7cd59492937d1c34feb8642
  Author: Julian Gross <julian.gross at dfki.de>
  Date:   2020-01-28 (Tue, 28 Jan 2020)

  Changed paths:
    M mlir/lib/Conversion/GPUToNVVM/LowerGpuOpsToNVVMOps.cpp
    M mlir/lib/Conversion/GPUToROCDL/LowerGpuOpsToROCDLOps.cpp
    M mlir/test/Conversion/GPUToNVVM/gpu-to-nvvm.mlir
    M mlir/test/Conversion/GPUToROCDL/gpu-to-rocdl.mlir

  Log Message:
  -----------
  Add tanh lowering from Standard dialect to NVVM and ROCDL.

Summary:
The tanh lowering from Standard dialect to NVVM and ROCDL was not working.
The conversion pattern are inserted in the lowering files.
The test cases for the lowerings were added in the test files.

Reviewers: nicolasvasilache, ftynse, herhut

Reviewed By: ftynse, herhut

Subscribers: merge_guards_bot, ftynse, jholewinski, mehdi_amini, rriddle, jpienaar, burmako, shauheen, antiagainst, csigg, arpith-jacob, mgester, lucyrfox, herhut, liufengdb, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D73471


  Commit: 88d6f18225e130b64939205e4c9ee4bfd7bb261d
      https://github.com/llvm/llvm-project/commit/88d6f18225e130b64939205e4c9ee4bfd7bb261d
  Author: Julian Gross <julian.gross at dfki.de>
  Date:   2020-01-28 (Tue, 28 Jan 2020)

  Changed paths:
    M mlir/include/mlir/Dialect/LLVMIR/LLVMOps.td
    M mlir/test/Target/llvmir-intrinsics.mlir

  Log Message:
  -----------
  [mlir] fixed invalid LLVM intrinsics in LLVMOPs.td and llvmir-intrinsics.mlir.

Summary:
The intrinsic operation added multiple type annotations to the llvm intrinsic operations, but only one is needed.
The related tests in llvmir-intrinsics.mlir checked the wrong number and are adjusted as well.

Reviewers: nicolasvasilache, ftynse

Reviewed By: ftynse

Subscribers: merge_guards_bot, ftynse, mehdi_amini, rriddle, jpienaar, burmako, shauheen, antiagainst, arpith-jacob, mgester, lucyrfox, liufengdb, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D73470


Compare: https://github.com/llvm/llvm-project/compare/92600c2ec832...88d6f18225e1