[all-commits] [llvm/llvm-project] 7596d3: [objc_direct] Allow for direct messages be sent to...

Pierre Habouzit via All-commits all-commits at lists.llvm.org
Thu Jan 23 22:58:38 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 7596d3c50c4b265612d326369e2a015cf8c60801
      https://github.com/llvm/llvm-project/commit/7596d3c50c4b265612d326369e2a015cf8c60801
  Author: Pierre Habouzit <phabouzit at apple.com>
  Date:   2020-01-23 (Thu, 23 Jan 2020)

  Changed paths:
    M clang/lib/Sema/SemaExprObjC.cpp
    A clang/test/SemaObjC/method-direct-arc.m
    M clang/test/SemaObjC/method-direct.m

  Log Message:
  -----------
  [objc_direct] Allow for direct messages be sent to `self` when it is a Class

Sending a message to `self` when it is const and within a class method
is safe because we know that `self` is the Class itself.

We can only relax this warning in ARC.

Signed-off-by: Pierre Habouzit <phabouzit at apple.com>
Radar-Id: rdar://problem/58581965
Differential Revision: https://reviews.llvm.org/D72747


  Commit: 52311d0483eecd60bdcc39dd3fb134f2412370f6
      https://github.com/llvm/llvm-project/commit/52311d0483eecd60bdcc39dd3fb134f2412370f6
  Author: Pierre Habouzit <phabouzit at apple.com>
  Date:   2020-01-23 (Thu, 23 Jan 2020)

  Changed paths:
    M clang/lib/CodeGen/CGObjCMac.cpp
    A clang/test/CodeGenObjC/direct-properties.m

  Log Message:
  -----------
  [objc_direct] do not add direct properties to the serialization array

If we do, then the property_list_t length is wrong
and class_getProperty gets very sad.

Signed-off-by: Pierre Habouzit <phabouzit at apple.com>
Radar-Id: rdar://problem/58804805
Differential Revision: https://reviews.llvm.org/D73219


Compare: https://github.com/llvm/llvm-project/compare/a50567a31c75...52311d0483ee


More information about the All-commits mailing list