[all-commits] [llvm/llvm-project] 04a151: [mlir] Swap use of to_vector() with lookupValues()...

Kariddi via All-commits all-commits at lists.llvm.org
Wed Jan 22 07:56:39 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 04a151710e8b04ca4c8e74782ceaadfe7ceca90c
      https://github.com/llvm/llvm-project/commit/04a151710e8b04ca4c8e74782ceaadfe7ceca90c
  Author: Marcello Maggioni <hayarms at gmail.com>
  Date:   2020-01-22 (Wed, 22 Jan 2020)

  Changed paths:
    M mlir/test/mlir-tblgen/llvm-intrinsics.td
    M mlir/tools/mlir-tblgen/LLVMIRIntrinsicGen.cpp

  Log Message:
  -----------
  [mlir] Swap use of to_vector() with lookupValues() in LLVMIRIntrinsicGen

Summary:
llvm::to_vector() accepts a Range value and not the pair of arguments
we are currently passing. Also we probably want the lowered LLVM
values in the vector, while operand_begin()/operand_end() on MLIR ops
returns MLIR types. lookupValues() seems the correct way to collect
such values.

Reviewers: rriddle, andydavis1, antiagainst, nicolasvasilache, ftynse

Subscribers: jdoerfert, mehdi_amini, jpienaar, burmako, shauheen, arpith-jacob, mgester, lucyrfox, liufengdb, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D73137




More information about the All-commits mailing list