[all-commits] [llvm/llvm-project] 7b0d58: Add testing for DW_OP_piece and fix a bug with sma...

[adrian-prantl via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 7b0d58e339b271e3b1d9dc14b781b57fa0262e3a
      https://github.com/llvm/llvm-project/commit/7b0d58e339b271e3b1d9dc14b781b57fa0262e3a
  Author: Adrian Prantl <aprantl at apple.com>
  Date:   2020-01-16 (Thu, 16 Jan 2020)

  Changed paths:
    M lldb/source/Expression/DWARFExpression.cpp
    M lldb/unittests/Expression/DWARFExpressionTest.cpp

  Log Message:
  -----------
  Add testing for DW_OP_piece and fix a bug with small Scalar values.

By switching to Scalars that are backed by explicitly-sized APInts we
can avoid a bug that increases the buffer reserved for a small piece
to the next-largest host integer type.

This manifests as "DW_OP_piece for offset foo but top of stack is of size bar".

Differential Revision: https://reviews.llvm.org/D72879


  Commit: f55ab6f90b7317a6bb85303a6102702bdae1199e
      https://github.com/llvm/llvm-project/commit/f55ab6f90b7317a6bb85303a6102702bdae1199e
  Author: Adrian Prantl <aprantl at apple.com>
  Date:   2020-01-16 (Thu, 16 Jan 2020)

  Changed paths:
    M lldb/source/Expression/DWARFExpression.cpp
    M lldb/unittests/Expression/DWARFExpressionTest.cpp

  Log Message:
  -----------
  Fix a buffer-size bug when the first DW_OP_piece is undefined

and document the shortcomings of LLDB's partially defined DW_OP_piece
handling.

This would manifest as "DW_OP_piece for offset foo but top of stack is
of size bar".

rdar://problem/46262998

Differential Revision: https://reviews.llvm.org/D72880


Compare: https://github.com/llvm/llvm-project/compare/2671df9bd675...f55ab6f90b73