[all-commits] [llvm/llvm-project] 337e43: [libcxx] [Windows] Make a more proper implementati...

Martin Storsjö via All-commits all-commits at lists.llvm.org
Tue Jan 14 12:29:55 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 337e4359645ebd0f35136dbec9b51c48b9071f9c
      https://github.com/llvm/llvm-project/commit/337e4359645ebd0f35136dbec9b51c48b9071f9c
  Author: Martin Storsjö <martin at martin.st>
  Date:   2020-01-14 (Tue, 14 Jan 2020)

  Changed paths:
    M libcxx/include/support/win32/locale_win32.h
    M libcxx/src/support/win32/locale_win32.cpp

  Log Message:
  -----------
  [libcxx] [Windows] Make a more proper implementation of strftime_l for mingw with msvcrt.dll

This also makes this function consistent with the rest of the
libc++ provided fallbacks.

The locale support in msvcrt.dll is very limited anyway; it can
only be configured processwide, not per thread, and it only seems
to support the locales "C" and "" (the user set locale), so it's
hard to make any meaningful automatic test for it. But manually tested,
this change does make time formatting locale code in libc++ output
times in the user requested format, when using locale "".

Differential Revision: https://reviews.llvm.org/D69554




More information about the All-commits mailing list