[all-commits] [llvm/llvm-project] 2a4368: [nfc][libomptarget] Refactor nvptx/target_impl.cu

Jon Chesterfield via All-commits all-commits at lists.llvm.org
Tue Jan 14 11:27:56 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 2a43688a0a074a70e395491fa0c3cdb4556ccea4
      https://github.com/llvm/llvm-project/commit/2a43688a0a074a70e395491fa0c3cdb4556ccea4
  Author: Jon Chesterfield <jonathanchesterfield at gmail.com>
  Date:   2020-01-14 (Tue, 14 Jan 2020)

  Changed paths:
    M openmp/libomptarget/deviceRTLs/nvptx/src/target_impl.cu

  Log Message:
  -----------
  [nfc][libomptarget] Refactor nvptx/target_impl.cu

Summary:
[nfc][libomptarget] Refactor nxptx/target_impl.cu

Use __kmpc_impl_atomic_add instead of atomicAdd to match the rest of the file.
Alternatively, target_impl.cu could use the cuda functions directly. Using a mixture in this
file was an oversight, happy to resolve in either direction.

Removed some comments that look outdated.

Call __kmpc_impl_unset_lock directly to avoid a redundant diagnostic and remove an implict
dependency on interface.h.

Reviewers: ABataev, grokos, jdoerfert

Reviewed By: jdoerfert

Subscribers: jfb, openmp-commits

Tags: #openmp

Differential Revision: https://reviews.llvm.org/D72719




More information about the All-commits mailing list