[all-commits] [llvm/llvm-project] 7ec7a6: Fix "null pointer passed to nonnull argument" clan...

[Simon Pilgrim via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 7ec7a6e5bfa745c285d5c651af02b93f2cb923e1
      https://github.com/llvm/llvm-project/commit/7ec7a6e5bfa745c285d5c651af02b93f2cb923e1
  Author: Simon Pilgrim <llvm-dev at redking.me.uk>
  Date:   2020-01-14 (Tue, 14 Jan 2020)

  Changed paths:
    M clang/lib/AST/NestedNameSpecifier.cpp

  Log Message:
  -----------
  Fix "null pointer passed to nonnull argument" clang static analyzer warnings. NFCI.

Assert that the memcpy arguments are valid.


  Commit: 25dc5c7cd159522ec2375544f473c757ee13a03b
      https://github.com/llvm/llvm-project/commit/25dc5c7cd159522ec2375544f473c757ee13a03b
  Author: Simon Pilgrim <llvm-dev at redking.me.uk>
  Date:   2020-01-14 (Tue, 14 Jan 2020)

  Changed paths:
    M clang/lib/CodeGen/CGObjC.cpp

  Log Message:
  -----------
  Fix "pointer is null" static analyzer warnings. NFCI.

Use castAs<> instead of getAs<> since the pointer is dereferenced immediately below and castAs will perform the null assertion for us.


  Commit: cc8a1504283731f05f937464b631f170d748b7b0
      https://github.com/llvm/llvm-project/commit/cc8a1504283731f05f937464b631f170d748b7b0
  Author: Simon Pilgrim <llvm-dev at redking.me.uk>
  Date:   2020-01-14 (Tue, 14 Jan 2020)

  Changed paths:
    M clang/lib/Sema/SemaExprObjC.cpp

  Log Message:
  -----------
  Merge isa<> and getAs<> calls to fix "pointer is null" static analyzer warnings. NFCI.


  Commit: 9d905e8ceddda8b103e208ed43a117cb4445e682
      https://github.com/llvm/llvm-project/commit/9d905e8ceddda8b103e208ed43a117cb4445e682
  Author: Simon Pilgrim <llvm-dev at redking.me.uk>
  Date:   2020-01-14 (Tue, 14 Jan 2020)

  Changed paths:
    M clang/lib/Sema/SemaExprObjC.cpp

  Log Message:
  -----------
  Remove duplicate variable. NFCI.


  Commit: 591cd40584300a1d5d33bfaefa4698c02ef56887
      https://github.com/llvm/llvm-project/commit/591cd40584300a1d5d33bfaefa4698c02ef56887
  Author: Simon Pilgrim <llvm-dev at redking.me.uk>
  Date:   2020-01-14 (Tue, 14 Jan 2020)

  Changed paths:
    M clang/lib/Sema/SemaTemplate.cpp

  Log Message:
  -----------
  Fix "pointer is null" static analyzer warnings. NFCI.

Use cast<> instead of cast_or_null<> since the pointers are always dereferenced and cast<> will perform the null assertion for us.


  Commit: 1d6b964ed1f7a77b178e86bef7d569611f2c0983
      https://github.com/llvm/llvm-project/commit/1d6b964ed1f7a77b178e86bef7d569611f2c0983
  Author: Simon Pilgrim <llvm-dev at redking.me.uk>
  Date:   2020-01-14 (Tue, 14 Jan 2020)

  Changed paths:
    M clang/lib/Sema/SemaTemplate.cpp

  Log Message:
  -----------
  Fix "pointer is null" static analyzer warning. NFCI.

Remove Ctx null test as clang static analyzer assumes that this can fail - replace it with an assertion as the pointer is always dereferenced below.


Compare: https://github.com/llvm/llvm-project/compare/a705cf1acbe9...1d6b964ed1f7