[all-commits] [llvm/llvm-project] 77da82: [lldb] Make CompleteTagDeclsScope completion order...

[Raphael Isemann via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 77da826edad0a7b906c734c6bee3489ef495c746
      https://github.com/llvm/llvm-project/commit/77da826edad0a7b906c734c6bee3489ef495c746
  Author: Raphael Isemann <teemperor at gmail.com>
  Date:   2020-01-10 (Fri, 10 Jan 2020)

  Changed paths:
    M lldb/source/Symbol/ClangASTImporter.cpp

  Log Message:
  -----------
  [lldb] Make CompleteTagDeclsScope completion order deterministic

Summary:
We iterate over `m_decls_to_complete` to complete declarations. As
`m_decls_to_complete` is a set the iteration order can be non-deterministic.
The order is currently only non-deterministic when we have
a large set of decls that need to be completed (i.e. more than 32 decls,
as otherwise the SmallPtrSet is just a linear-searched list).

This doesn't really fix any specific bug or has any really observable
change in behavior as the order in which we import should not influence
any semantics. However the order we create decls/types is now always
deterministic which should make debugging easier.

Reviewers: labath, mib, shafik, davide

Reviewed By: shafik, davide

Subscribers: davide, abidh, JDevlieghere, lldb-commits, mgrang

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D72495