[all-commits] [llvm/llvm-project] a5bdad: [X86][AVX] lowerShuffleAsLanePermuteAndShuffle - c...

Simon Pilgrim via All-commits all-commits at lists.llvm.org
Fri Jan 10 09:21:56 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: a5bdada09defc15d2b009314306f4fcb8fa8458d
      https://github.com/llvm/llvm-project/commit/a5bdada09defc15d2b009314306f4fcb8fa8458d
  Author: Simon Pilgrim <llvm-dev at redking.me.uk>
  Date:   2020-01-10 (Fri, 10 Jan 2020)

  Changed paths:
    M llvm/lib/Target/X86/X86ISelLowering.cpp

  Log Message:
  -----------
  [X86][AVX] lowerShuffleAsLanePermuteAndShuffle - consistently normalize multi-input shuffle elements

We only use lowerShuffleAsLanePermuteAndShuffle for unary shuffles at the moment, but we should consistently handle lane index calculations for multiple inputs in both the AVX1 and AVX2 paths.

Minor (almost NFC) tidyup as I'm hoping to use lowerShuffleAsLanePermuteAndShuffle for binary shuffles soon.


  Commit: cdc9592bf1acb6d8012a4867d2a22458945dcceb
      https://github.com/llvm/llvm-project/commit/cdc9592bf1acb6d8012a4867d2a22458945dcceb
  Author: Simon Pilgrim <llvm-dev at redking.me.uk>
  Date:   2020-01-10 (Fri, 10 Jan 2020)

  Changed paths:
    M clang/lib/ARCMigrate/ObjCMT.cpp

  Log Message:
  -----------
  Fix "pointer is null" static analyzer warning. NFCI.

Use cast<> instead of dyn_cast<> since we know that the pointer should be valid (and is dereferenced immediately).


  Commit: cce4676d6d78ba56e929bd37d65c2667390b68c7
      https://github.com/llvm/llvm-project/commit/cce4676d6d78ba56e929bd37d65c2667390b68c7
  Author: Simon Pilgrim <llvm-dev at redking.me.uk>
  Date:   2020-01-10 (Fri, 10 Jan 2020)

  Changed paths:
    M clang/lib/ARCMigrate/ObjCMT.cpp

  Log Message:
  -----------
  Fix "pointer is null" static analyzer warning. NFCI.

Use castAs<> instead of getAs<> since the pointer is dereferenced immediately below and castAs will perform the null assertion for us.


Compare: https://github.com/llvm/llvm-project/compare/504b3fe5bfed...cce4676d6d78


More information about the All-commits mailing list