[all-commits] [llvm/llvm-project] f0fd11: [FPEnv] Invert sense of MIFlag::FPExcept flag

Ulrich Weigand via All-commits all-commits at lists.llvm.org
Fri Jan 10 06:35:30 PST 2020


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: f0fd11df7d5488e2747f26a3bfcf62459fee54ad
      https://github.com/llvm/llvm-project/commit/f0fd11df7d5488e2747f26a3bfcf62459fee54ad
  Author: Ulrich Weigand <ulrich.weigand at de.ibm.com>
  Date:   2020-01-10 (Fri, 10 Jan 2020)

  Changed paths:
    M llvm/include/llvm/CodeGen/MachineInstr.h
    M llvm/lib/CodeGen/MIRParser/MILexer.cpp
    M llvm/lib/CodeGen/MIRParser/MILexer.h
    M llvm/lib/CodeGen/MIRParser/MIParser.cpp
    M llvm/lib/CodeGen/MIRPrinter.cpp
    M llvm/lib/CodeGen/MachineInstr.cpp
    M llvm/lib/CodeGen/SelectionDAG/InstrEmitter.cpp
    M llvm/lib/Target/SystemZ/SystemZElimCompare.cpp
    M llvm/test/CodeGen/X86/fast-isel-select-sse.ll
    M llvm/test/CodeGen/X86/fp-intrinsics-flags-x86_64.ll
    M llvm/test/CodeGen/X86/fp-intrinsics-flags.ll
    M llvm/test/CodeGen/X86/sqrt-fastmath-mir.ll
    M llvm/test/CodeGen/X86/vector-constrained-fp-intrinsics-flags.ll

  Log Message:
  -----------
  [FPEnv] Invert sense of MIFlag::FPExcept flag

In D71841 we inverted the sense of the SDNode-level flag to ensure all nodes
default to potentially raising FP exceptions unless otherwise specified --
i.e. if we forget to propagate the flag somewhere, the effect is now only
lost performance, not incorrect code.

However, the related flag at the MI level still defaults to nodes not raising
FP exceptions unless otherwise specified. To be fully on the (conservatively)
safe side, we should invert that flag as well.

This patch does so by replacing MIFlag::FPExcept with MIFlag::NoFPExcept.
(Note that this does also introduce an incompatible change in the MIR format.)

Reviewed By: craig.topper

Differential Revision: https://reviews.llvm.org/D72466




More information about the All-commits mailing list