[all-commits] [llvm/llvm-project] 6c1d72: [llvm-readobj][llvm-objdump] - Cleanup testing of ...

Georgii Rymar via All-commits all-commits at lists.llvm.org
Thu Dec 19 00:18:12 PST 2019


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 6c1d72b03963a9455ff8a272c6f5be3e8e48cb49
      https://github.com/llvm/llvm-project/commit/6c1d72b03963a9455ff8a272c6f5be3e8e48cb49
  Author: Georgii Rymar <grimar at accesssoftek.com>
  Date:   2019-12-19 (Thu, 19 Dec 2019)

  Changed paths:
    M llvm/test/tools/llvm-objdump/elf-dynamic-section-machine-specific.test
    R llvm/test/tools/llvm-readobj/ELF/Inputs/elf-dynamic-tags-machine-specific.yaml
    M llvm/test/tools/llvm-readobj/ELF/dynamic-tags-machine-specific.test

  Log Message:
  -----------
  [llvm-readobj][llvm-objdump] - Cleanup testing of dynamic tags dumping.

We have the `elf-dynamic-tags-machine-specific.yaml` input shared
between the llvm-readobj and llvm-objdump test.
It looks strange, because tools usually does not share inputs.

Also there are following problems related:
1) `elf-dynamic-tags-machine-specific.yaml` input contains excessive YAML parts.
2) objdump's test case never test AARCH64 tags.
3) There are unknown tags in the `elf-dynamic-tags-machine-specific.yaml` and
    `dynamic-tags-machine-specific.test`, though we already testing unknown tags
    in `\llvm-readobj\ELF\dynamic-tags.test` and `llvm-objdump\elf-dynamic-section.test` tests.

This patch removes the shared input and refines the test cases to resolve
issues mentioned.

Differential revision: https://reviews.llvm.org/D71602




More information about the All-commits mailing list