[all-commits] [llvm/llvm-project] d14a56: MSVC build fix: forget some unneeded and incorrect...

John McCall via All-commits all-commits at lists.llvm.org
Fri Dec 13 22:02:22 PST 2019


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: d14a5693c07f0fb1b82c75ed72f77a495751dcf7
      https://github.com/llvm/llvm-project/commit/d14a5693c07f0fb1b82c75ed72f77a495751dcf7
  Author: John McCall <rjmccall at apple.com>
  Date:   2019-12-14 (Sat, 14 Dec 2019)

  Changed paths:
    M clang/include/clang/Serialization/ASTReader.h
    M clang/include/clang/Serialization/ASTWriter.h

  Log Message:
  -----------
  MSVC build fix: forget some unneeded and incorrect friends.

On MSVC, friend declarations are (incorrectly) visible even if
not otherwise declared, which causes them to interfere with
lookup.  ASTTypeWriter is actually in an anonymous namespace
and cannot be ASTWriter's friend.  The others simply don't need
to be anymore.




More information about the All-commits mailing list