[all-commits] [llvm/llvm-project] 9bace2: [lldb][NFC] Remove all `setUp` overrides that only...

Raphael Isemann via All-commits all-commits at lists.llvm.org
Fri Dec 13 03:35:12 PST 2019


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 9bace26a690a778ec0f09a9aae9537dfbdb6f42f
      https://github.com/llvm/llvm-project/commit/9bace26a690a778ec0f09a9aae9537dfbdb6f42f
  Author: Raphael Isemann <teemperor at gmail.com>
  Date:   2019-12-13 (Fri, 13 Dec 2019)

  Changed paths:
    M lldb/packages/Python/lldbsuite/test/api/listeners/TestListener.py
    M lldb/packages/Python/lldbsuite/test/commands/apropos/basic/TestApropos.py
    M lldb/packages/Python/lldbsuite/test/commands/command/script/import/TestImport.py
    M lldb/packages/Python/lldbsuite/test/commands/command/script/import/rdar-12586188/TestRdar12586188.py
    M lldb/packages/Python/lldbsuite/test/commands/disassemble/basic/TestFrameDisassemble.py
    M lldb/packages/Python/lldbsuite/test/commands/expression/calculator_mode/TestCalculatorMode.py
    M lldb/packages/Python/lldbsuite/test/commands/expression/dont_allow_jit/TestAllowJIT.py
    M lldb/packages/Python/lldbsuite/test/commands/expression/entry-bp/TestExprEntryBP.py
    M lldb/packages/Python/lldbsuite/test/commands/expression/persistent_ptr_update/TestPersistentPtrUpdate.py
    M lldb/packages/Python/lldbsuite/test/commands/expression/weak_symbols/TestWeakSymbols.py
    M lldb/packages/Python/lldbsuite/test/commands/frame/diagnose/array/TestArray.py
    M lldb/packages/Python/lldbsuite/test/commands/frame/language/TestGuessLanguage.py
    M lldb/packages/Python/lldbsuite/test/commands/frame/var/TestFrameVar.py
    M lldb/packages/Python/lldbsuite/test/commands/register/register/intel_xtended_registers/TestMPXRegisters.py
    M lldb/packages/Python/lldbsuite/test/commands/register/register/intel_xtended_registers/mpx_offset_intersection/TestMPXOffsetIntersection.py
    M lldb/packages/Python/lldbsuite/test/commands/target/stop-hooks/TestStopHooks.py
    M lldb/packages/Python/lldbsuite/test/commands/version/TestVersion.py
    M lldb/packages/Python/lldbsuite/test/commands/watchpoints/watchpoint_disable/TestWatchpointDisable.py
    M lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/address_breakpoints/TestAddressBreakpoints.py
    M lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/address_breakpoints/TestBadAddressBreakpoints.py
    M lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/auto_continue/TestBreakpointAutoContinue.py
    M lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_language/TestBreakpointLanguage.py
    M lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/scripted_bkpt/TestScriptedResolver.py
    M lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-caching/TestDataFormatterCaching.py
    M lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/type_summary_list_arg/TestTypeSummaryListArg.py
    M lldb/packages/Python/lldbsuite/test/functionalities/history/TestHistoryRecall.py
    M lldb/packages/Python/lldbsuite/test/functionalities/longjmp/TestLongjmp.py
    M lldb/packages/Python/lldbsuite/test/functionalities/pre_run_dylibs/TestPreRunDylibs.py
    M lldb/packages/Python/lldbsuite/test/functionalities/stats_api/TestStatisticsAPI.py
    M lldb/packages/Python/lldbsuite/test/functionalities/tail_call_frames/sbapi_support/TestTailCallFrameSBAPI.py
    M lldb/packages/Python/lldbsuite/test/functionalities/tail_call_frames/thread_step_out_or_return/TestSteppingOutWithArtificialFrames.py
    M lldb/packages/Python/lldbsuite/test/functionalities/thread/backtrace_limit/TestBacktraceLimit.py
    M lldb/packages/Python/lldbsuite/test/functionalities/tsan/cpp_global_location/TestTsanCPPGlobalLocation.py
    M lldb/packages/Python/lldbsuite/test/functionalities/tsan/global_location/TestTsanGlobalLocation.py
    M lldb/packages/Python/lldbsuite/test/functionalities/tsan/multiple/TestTsanMultiple.py
    M lldb/packages/Python/lldbsuite/test/functionalities/tsan/thread_numbers/TestTsanThreadNumbers.py
    M lldb/packages/Python/lldbsuite/test/functionalities/var_path/TestVarPath.py
    M lldb/packages/Python/lldbsuite/test/lang/c/find_struct_type/TestFindStructTypes.py
    M lldb/packages/Python/lldbsuite/test/lang/c/local_types/TestUseClosestType.py
    M lldb/packages/Python/lldbsuite/test/lang/cpp/dynamic-value-same-basename/TestDynamicValueSameBase.py
    M lldb/packages/Python/lldbsuite/test/lang/cpp/trivial_abi/TestTrivialABI.py
    M lldb/packages/Python/lldbsuite/test/lang/objc/modules-app-update/TestClangModulesAppUpdate.py
    M lldb/packages/Python/lldbsuite/test/lang/objc/modules-cache/TestClangModulesCache.py
    M lldb/packages/Python/lldbsuite/test/lang/objc/modules-hash-mismatch/TestClangModulesHashMismatch.py
    M lldb/packages/Python/lldbsuite/test/lang/objc/modules-inline-functions/TestModulesInlineFunctions.py
    M lldb/packages/Python/lldbsuite/test/lang/objc/modules-update/TestClangModulesUpdate.py
    M lldb/packages/Python/lldbsuite/test/lang/objcxx/cxx-bridged-po/TestObjCXXBridgedPO.py
    M lldb/packages/Python/lldbsuite/test/lang/objcxx/hide-runtime-values/TestObjCXXHideRuntimeValues.py
    M lldb/packages/Python/lldbsuite/test/linux/mix-dwo-and-regular-objects/TestMixedDwarfBinary.py
    M lldb/packages/Python/lldbsuite/test/macosx/find-app-in-bundle/TestFindAppInBundle.py
    M lldb/packages/Python/lldbsuite/test/macosx/thread-names/TestInterruptThreadNames.py
    M lldb/packages/Python/lldbsuite/test/macosx/version_zero/TestGetVersionZeroVersion.py
    M lldb/packages/Python/lldbsuite/test/python_api/process/io/TestProcessIO.py
    M lldb/packages/Python/lldbsuite/test/python_api/sbstructureddata/TestStructuredDataAPI.py
    M lldb/packages/Python/lldbsuite/test/python_api/value_var_update/TestValueVarUpdate.py

  Log Message:
  -----------
  [lldb][NFC] Remove all `setUp` overrides that only call the parent implementation

Summary:
A lot of our tests copied the setUp code from our TestSampleTest.py:

```
    def setUp(self):
        # Call super's setUp().
        TestBase.setUp(self)
```

This code does nothing unless we actually do any setUp work in there, so let's remove all these method definitions.

Reviewers: labath, JDevlieghere

Reviewed By: labath

Subscribers: lldb-commits

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D71454




More information about the All-commits mailing list