[all-commits] [llvm/llvm-project] 70e3d0: [FormatManager] Move Language lookup into the obvi...

adrian-prantl via All-commits all-commits at lists.llvm.org
Tue Dec 10 15:58:44 PST 2019


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 70e3d0ea55e8b9385168d389fcba16a283f20214
      https://github.com/llvm/llvm-project/commit/70e3d0ea55e8b9385168d389fcba16a283f20214
  Author: Adrian Prantl <aprantl at apple.com>
  Date:   2019-12-10 (Tue, 10 Dec 2019)

  Changed paths:
    M lldb/source/DataFormatters/FormatManager.cpp

  Log Message:
  -----------
  [FormatManager] Move Language lookup into the obviously non-cached part (NFC)

This refactoring makes the lookup caching easier to reason about. This
has no observable effect although it does slightly change what is
being cached.

- Before this patch a negative lookup in the LanguageCategory would be
  cached, but a positive wouldn't.

- After this patch LanguageCategory lookups aren't cached by
  FormatManager, period. (LanguageCategory has its own FormatCache for this!)

Differential Revision: https://reviews.llvm.org/D71289




More information about the All-commits mailing list