[all-commits] [llvm/llvm-project] d94666: [llvm/dwarfdump] Use the architecture string to fi...

[Jonas Devlieghere via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: d9466653e4ddbde5e787ac8cdbe67c1f356a5f69
      https://github.com/llvm/llvm-project/commit/d9466653e4ddbde5e787ac8cdbe67c1f356a5f69
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2019-12-09 (Mon, 09 Dec 2019)

  Changed paths:
    M llvm/test/tools/llvm-dwarfdump/AArch64/arch.ll
    A llvm/test/tools/llvm-dwarfdump/filter.test
    M llvm/tools/llvm-dwarfdump/llvm-dwarfdump.cpp

  Log Message:
  -----------
  [llvm/dwarfdump] Use the architecture string to filter.

Currently dwarfdump uses the ArchType to filter out architectures, which
is problematic for architectures like arm64e and x86_64h that map back
to arm64 and x86_64 respectively. The result is that the filter doesn't
work for these architectures because it matches all the variants. This
is especially bad because usually these architectures are the reason to
use the filter in the first place.

Instead, we should match the architecture based on the string name. This
means the filter works for the values printed by dwarfdump. It has the
unfortunate side effect of not working for aliases, like AArch64, but I
think that's worth the trade-off.

rdar://53653014

Differential revision: https://reviews.llvm.org/D71230