[all-commits] [llvm/llvm-project] 7caa17: [lldb][NFC] Move Curses interface implementation t...

Raphael Isemann via All-commits all-commits at lists.llvm.org
Tue Dec 3 05:03:34 PST 2019


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 7caa17caf8e290fb865ac81470da737056ab0ace
      https://github.com/llvm/llvm-project/commit/7caa17caf8e290fb865ac81470da737056ab0ace
  Author: Raphael Isemann <teemperor at gmail.com>
  Date:   2019-12-03 (Tue, 03 Dec 2019)

  Changed paths:
    M lldb/include/lldb/Core/IOHandler.h
    A lldb/include/lldb/Core/IOHandlerCursesGUI.h
    M lldb/source/Commands/CommandObjectGUI.cpp
    M lldb/source/Core/CMakeLists.txt
    M lldb/source/Core/IOHandler.cpp
    A lldb/source/Core/IOHandlerCursesGUI.cpp

  Log Message:
  -----------
  [lldb][NFC] Move Curses interface implementation to own file

Summary:
The IOHandler class source file is currently around 4600 LOC. However only 200
of these lines are concerned with the actual IOHandler class and the rest are the
implementations for Editline, IOHandlerConfirm and the Curses interface. All these
large features also cause that the IOHandler (which is in Core) has a large set of dependencies
on other parts of LLDB.

This patch splits out the code for the curses interface into its own file. This way
the simple IOHandler code is no longer buried in-between much larger functionalities.

Next up is splitting out the other IOHandlers into their own files and then move them
to more appropriate parts of LLDB.

Reviewers: labath, clayborg, JDevlieghere

Reviewed By: labath

Subscribers: mgorny, lldb-commits

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D70946




More information about the All-commits mailing list