[all-commits] [llvm/llvm-project] 039664: [LegalizeDAG] Return true from ExpandNode for some...

topperc via All-commits all-commits at lists.llvm.org
Mon Dec 2 23:40:34 PST 2019


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 039664db87d255570854ade5241bf53b8ce3b5a9
      https://github.com/llvm/llvm-project/commit/039664db87d255570854ade5241bf53b8ce3b5a9
  Author: Craig Topper <craig.topper at gmail.com>
  Date:   2019-12-02 (Mon, 02 Dec 2019)

  Changed paths:
    M llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp

  Log Message:
  -----------
  [LegalizeDAG] Return true from ExpandNode for some nodes that don't have expand support.

These nodes have a FIXME that they only get here because a Custom
handler returned SDValue() instead of the original Op.

Even though we aren't expanding them, we should return true here to
prevent ConvertNodeToLibcall from also trying to process them until
the FIXME has been addressed.

I'm hoping to add checking to ConvertNodeToLibcall to make sure
we don't give it nodes it doesn't have support for.




More information about the All-commits mailing list