[all-commits] [llvm/llvm-project] 711c66: Fix comment to more accurately describe C++ langua...

Richard Smith via All-commits all-commits at lists.llvm.org
Mon Dec 2 14:41:34 PST 2019


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 711c669ae92658aecc6fabccc583594924bac6d7
      https://github.com/llvm/llvm-project/commit/711c669ae92658aecc6fabccc583594924bac6d7
  Author: Richard Smith <richard at metafoo.co.uk>
  Date:   2019-12-02 (Mon, 02 Dec 2019)

  Changed paths:
    M clang/include/clang/Basic/TargetCXXABI.h

  Log Message:
  -----------
  Fix comment to more accurately describe C++ language requirements around tail padding.

Summary:
As of C++ core issue 43 (http://wg21.link/cwg43), which was voted into
the C++ working draft in 1999, it is not permissible to memcpy a base
class subobject, even if it's of POD type, so there is no problem with
reusing the tail padding of a base class. That issue was voted into the
standard in DR status, so it applies retroactively to C++98 (and is in
any case part of C++03).

So stop suggesting that AlwaysUseTailPadding mode is non-conforming.

Reviewers: rjmccall

Reviewed By: rjmccall

Subscribers: cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D70923




More information about the All-commits mailing list